Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent negative values on gas inputs. #8533

Merged
merged 1 commit into from
May 6, 2020
Merged

Prevent negative values on gas inputs. #8533

merged 1 commit into from
May 6, 2020

Conversation

tmashuang
Copy link
Contributor

Fixes #8492

Adds min value for input in the advanced-gas-inputs component to prevent users from entering negative values on keypress, change, etc.

@tmashuang
Fixes #8492
0c38e0c 
Adds min value for input in the advanced-gas-inputs component to prevent users from entering negative values on keypress, change, etc.
@tmashuang tmashuang requested a review from a team as a code owner May 6, 2020 01:03
rekmarks
rekmarks approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [0c38e0c]
Page Load Metrics (619 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29403342
domContentLoaded5796796172713
load5806806192713
domInteractive5796786172713

brad-decker
brad-decker approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

whymarrh
whymarrh approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang tmashuang merged commit 39dad37 into develop May 6, 2020
@tmashuang tmashuang deleted the prevent-negative-number branch May 6, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@brad-decker brad-decker brad-decker approved these changes

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative gas price breaks the extension
5 participants
@tmashuang @metamaskbot @whymarrh @brad-decker @rekmarks