Remove scroll bar from home screen

[Gudahtt]

A change made in #8284 had the unintended side-effect of making this scrollbar appear on the home screen. Previously it was scrollable without any scroll bar being visible.

[Gudahtt]

Screenshots:

With scrollbar (before):

Without scrollbar (after):

[metamaskbot]

Builds ready [563309a]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (654 ± 35 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	30	99	41	17	8
		domContentLoaded	374	772	653	73	35
		load	375	773	654	73	35
		domInteractive	373	771	652	73	35

[brad-decker]

@Gudahtt is this issue caused by an overlap of the mentioned change and my updates in #8433 ?

[Gudahtt]

@brad-decker I thought so at first too, but apparently not. I compared before and after #8433, and this particular scrollbar remained unchanged. I did a git bisect, and found that it was introduced in #8284.

[brad-decker]

Sweet. How did you use git bisect with a visual regression? E2E test to check if the scrollbar was visible?

[Gudahtt]

I just manually ran yarn then yarn start for each commit, and looked at the extension in the browser. Probably not the most efficient process 😅 But it works.

[brad-decker]

Bet you spent less time doing that than it would have taken to write a test to look for a scrollbar, lol.