Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete recent blocks controller #8575

Merged
merged 2 commits into from
May 12, 2020
Merged

Delete recent blocks controller #8575

merged 2 commits into from
May 12, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented May 12, 2020

Motivation

We had already stopped polling for blocks on default (Infura) networks, and it was recently decided that we would stop doing it on custom (manually entered RPC endpoint) networks as well.

After removing all polling from the recent blocks controller, that controller no longer served any purpose, so it and all its related state has been deleted.

Changes in Detail

  • All references to recentBlocks have been deleted from the UI and background.
  • This PR requires no migration because we stopped persisting recentBlocks in remove BlacklistController from disk state #3148.
  • percentile is deleted from the direct dependencies, because all uses of it have been removed.

Future Considerations

We should consider adding an eth_gasPrice call in the transaction retry flow, but that should probably be done in a follow-up PR.

@rekmarks rekmarks requested a review from a team as a code owner May 12, 2020 17:33
@metamaskbot
Copy link
Collaborator

Builds ready [becb810]
Page Load Metrics (625 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3310043189
domContentLoaded40278262311254
load40478462511154
domInteractive40278262311254

@metamaskbot
Copy link
Collaborator

Builds ready [b6147bf]
Page Load Metrics (590 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298443178
domContentLoaded33887958813766
load33988059013766
domInteractive33787958813766

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants