Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Seed Phrase Functionality on Account Import #8730

Merged
merged 18 commits into from
Jun 11, 2020
Merged

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Jun 3, 2020

I had the thought the other day that the seed phrase input should be treated as a password; any user using something like pass doesn't really need to have the seed phrase visible in the UI (and likely doesn't want it to be?).

Rational:

I keep my seedphrase in a password manager that has a "copy to clipboard" functionality. the idea being that I never want to display my seedphrase (or passwords) on screen (in plain text). the textarea is now a password field and you can toggle back to a textarea if you need to:

By default the seed phrase input is treated as a password field waiting to accept precious data from the user clipboard:

image

Now I can import my seedphrase without ever displaying it on screen:

image

If I need to input the seed phrase manually i can choose to show the seed phrase textarea:

image

Notes:

This obviously needs some design love, some text to be translated etc. but I just wanted to open this to kick off a conversation.

This should be good now that we've had input from the design team

@rickycodes rickycodes requested a review from a team as a code owner June 3, 2020 17:41
@metamaskbot
Copy link
Collaborator

Builds ready [2ea4464]
Page Load Metrics (615 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3211643188
domContentLoaded37984161315474
load38184361515474
domInteractive37984161315474

rickycodes and others added 5 commits June 4, 2020 10:46
…phrase/import-with-seed-phrase.component.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
…phrase/import-with-seed-phrase.component.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
Gudahtt previously approved these changes Jun 4, 2020
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [96d8a78]
Page Load Metrics (709 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30116673115
domContentLoaded43699470719292
load44299570919292
domInteractive43599470719292

@rickycodes rickycodes changed the title Add option to hide seedphrase Update Seed Phrase Functionality on Account Import Jun 4, 2020
@danfinlay
Copy link
Contributor

As a password manager user who uses it with MetaMask, this would make me comfortable swapping vaults while sharing screen, and that’s neat!

@rickycodes rickycodes force-pushed the hide-seed-phrase branch 4 times, most recently from 1bc5e17 to be61549 Compare June 5, 2020 05:34
@metamaskbot
Copy link
Collaborator

Builds ready [d5f0d37]
Page Load Metrics (854 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded522107685116378
load524108085416378
domInteractive522107585016378

@rickycodes rickycodes requested review from whymarrh and Gudahtt June 8, 2020 21:33
whymarrh
whymarrh previously approved these changes Jun 9, 2020
@rachelcope
Copy link

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [6029211]
Page Load Metrics (634 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint348243115
domContentLoaded35094063316579
load35794263416579
domInteractive35094063216579

Copy link

@rachelcope rachelcope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good!

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants