-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Seed Phrase Functionality on Account Import #8730
Conversation
9a4eac7
to
a22416f
Compare
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
Builds ready [2ea4464]
Page Load Metrics (615 ± 74 ms)
|
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
…phrase/import-with-seed-phrase.component.js Co-authored-by: Mark Stacey <markjstacey@gmail.com>
…phrase/import-with-seed-phrase.component.js Co-authored-by: Mark Stacey <markjstacey@gmail.com>
a451855
to
96d8a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [96d8a78]
Page Load Metrics (709 ± 92 ms)
|
As a password manager user who uses it with MetaMask, this would make me comfortable swapping vaults while sharing screen, and that’s neat! |
1bc5e17
to
be61549
Compare
be61549
to
d5f0d37
Compare
Builds ready [d5f0d37]
Page Load Metrics (854 ± 78 ms)
|
LGTM! |
Builds ready [6029211]
Page Load Metrics (634 ± 79 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I had the thought the other day that the seed phrase input should be treated as a password; any user using something like
pass
doesn't really need to have the seed phrase visible in the UI (and likely doesn't want it to be?).Rational:
I keep my seedphrase in a password manager that has a "copy to clipboard" functionality. the idea being that I never want to display my seedphrase (or passwords) on screen (in plain text). the textarea is now a password field and you can toggle back to a textarea if you need to:
By default the seed phrase input is treated as a password field waiting to accept precious data from the user clipboard:
Now I can import my seedphrase without ever displaying it on screen:
If I need to input the seed phrase manually i can choose to show the seed phrase textarea:
Notes:
This obviously needs some design love, some text to be translated etc. but I just wanted to open this to kick off a conversation.This should be good now that we've had input from the design team