-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions: Do not display HTTP/HTTPS URL schemes for unique hosts #8768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the title
Strip scheme from domain URL origins for unique hosts
Permissions: Do not display HTTP/HTTPS URL schemes for unique hosts
Jun 8, 2020
rekmarks
force-pushed
the
perm-origin-scheme-display
branch
from
June 8, 2020 23:00
5afbed1
to
72e3533
Compare
Builds ready [72e3533]
Page Load Metrics (626 ± 69 ms)
|
Gudahtt
reviewed
Jun 9, 2020
ui/app/components/app/connected-sites-list/connected-sites-list.component.js
Outdated
Show resolved
Hide resolved
…t.component.js Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [3559a53]
Page Load Metrics (618 ± 71 ms)
|
Gudahtt
added a commit
that referenced
this pull request
Jun 10, 2020
* origin/develop: (35 commits) Delete unused InfuraController & tests (#8773) Permissions: Do not display HTTP/HTTPS URL schemes for unique hosts (#8768) Refactor confirm approve page (#8757) blocklisted -> blocked Update app/scripts/contentscript.js blacklist -> blocklist; whitelist -> safelist replace blacklist with blocklist Delete unused transaction history test state (#8769) fix-formatting-of-gif (#8767) Order accounts on connect page (#8762) add gif for loading dev build (#8766) Bump websocket-extensions from 0.1.3 to 0.1.4 (#8759) Fix prop type mismatch (#8754) use grid template to position list item (#8753) Fix account menu entry for imported accounts (#8747) Fix permissions connect close and redirect behavior (#8751) Refactor `TokenBalance` component (#8752) Fix 'Remove account' in Account Options menu (#8748) move activation logic into token rates controller (#8744) asset outdated warning inline on full screen (#8734) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminology
URL components recap:
https://metamask.io:9000
https
9000
metamask.io:9000
port
displayed, as almost all HTTP/HTTPS websites use default ports, and the Chrome APIs don't even bother giving the default ports to us.metamask.io
Changes
These changes required updates to permissions controller and selector tests. The majority of the changes (by lines) are due to changing a commonly used constant in the permissions controller tests.
Updates the permission origin string display to conform to the following:
http://foo.bar
can be connected toAccount 1
, andhttps://foo.bar
can be connected toAccount 2
, and the schemes will be displayed for both sites, even if they'll never appear in the same connected sites list.https://foo.bar:9000
andhttps://foo.bar:9001
will be displayed asfoo.bar:9000
andfoo.bar:9001
, respectively.These changes do not affect external domains that are extension (i.e., their domain metadata has a truthy
extensionId
property).