Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'History' tab to 'Activity' #8785

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 11, 2020

'Activity' is a better name for this tab because it contains more than just transactions. Signature requests are also included, and more non-transaction activity may be included in the future.

Base automatically changed from use-localized-tab-names to develop June 11, 2020 18:19
'Activity' is a better name for this tab because it contains more than
just transactions. Signature requests are also included, and more non-
transaction activity may be included in the future.
@Gudahtt Gudahtt force-pushed the rename-history-tab-to-activity branch from 3a2c0a1 to 8002273 Compare June 11, 2020 18:19
@Gudahtt Gudahtt marked this pull request as ready for review June 11, 2020 18:39
@Gudahtt Gudahtt requested a review from a team as a code owner June 11, 2020 18:39
@metamaskbot
Copy link
Collaborator

Builds ready [8002273]
Page Load Metrics (668 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint309341178
domContentLoaded6118326666431
load6138336686431
domInteractive6118326666431

@Gudahtt Gudahtt merged commit 4ac4790 into develop Jun 11, 2020
@Gudahtt Gudahtt deleted the rename-history-tab-to-activity branch June 11, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants