Fix handling of permissions of removed accounts #8803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
fix-handling-of-removed-account-permissions
branch
from
31b1479 to
592c57d
Compare
Imported accounts can be removed, but the permissions controller is not informed when this happens. Permissions are now removed as part of the account removal process. Additionally, the `getPermittedIdentitiesForCurrentTab` selector now filters out any non-existent accounts, in case a render occurs in the middle of an account removal. This was resulting in a render crash upon opening the popup on a site that was connected to the removed account.
Gudahtt
force-pushed
the
fix-handling-of-removed-account-permissions
branch
from
592c57d to
879eeef
Compare
Builds ready [879eeef]
Page Load Metrics (685 ± 38 ms)
|
Gudahtt
added a commit
that referenced
this pull request
Jun 16, 2020
* origin/develop: (58 commits) Fix site icon fallback letter (#8815) add hover style to list-item (#8813) Fix site icon size (#8814) Consolidate connected account alerts (#8802) lowercase web3 Use markdown-to-jsx@6.11.4 (#8809) Update app/_locales/en/messages.json Update app/_locales/en/messages.json also remove 'dapp' from descriptions remove all user-facing instances of 'dapp' update button styling on home/asset page (#8800) Fix handling of permissions of removed accounts (#8803) Clear permssions during createNewVaultAndRestore (#8804) Hide token transfers on ETH asset page (#8799) Fix account name editing (#8801) Fix connect flow account list height (#8798) Update color of menu item icons (#8797) Update "Connected accounts" empty description (#8796) Stop reporting failed transactions to Sentry (#8795) Omit state snapshot from Sentry errors (#8794) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported accounts can be removed, but the permissions controller is not informed when this happens. Permissions are now removed as part of the account removal process.
Additionally, the
getPermittedIdentitiesForCurrentTabselector now filters out any non-existent accounts, in case a render occurs in the middle of an account removal.This was resulting in a render crash upon opening the popup on a site that was connected to the removed account.