Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all user- and translator-facing instances of 'dapp' #8810

Merged
merged 6 commits into from
Jun 15, 2020
Merged

Remove all user- and translator-facing instances of 'dapp' #8810

merged 6 commits into from
Jun 15, 2020

Conversation

rekmarks
Copy link
Member

Self-explanatory.

@rekmarks rekmarks requested a review from a team as a code owner June 15, 2020 18:32
whymarrh
whymarrh previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks changed the title Remove all user-facing instances of 'dapp' Remove all user- or translator-facing instances of 'dapp' Jun 15, 2020
brad-decker
brad-decker previously approved these changes Jun 15, 2020
View reviewed changes
@rekmarks rekmarks changed the title Remove all user- or translator-facing instances of 'dapp' Remove all user- and translator-facing instances of 'dapp' Jun 15, 2020
whymarrh
whymarrh suggested changes Jun 15, 2020
View reviewed changes
app/_locales/en/messages.json Outdated Show resolved Hide resolved
app/_locales/en/messages.json Outdated Show resolved Hide resolved
@rekmarks @whymarrh
Update app/_locales/en/messages.json
2267962 
Co-authored-by: Whymarrh Whitby <whymarrh.whitby@gmail.com>
@rekmarks @whymarrh
Update app/_locales/en/messages.json
7f47eb5 
Co-authored-by: Whymarrh Whitby <whymarrh.whitby@gmail.com>
whymarrh
whymarrh previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But could you also lower-case the one place where Web3 is currently capitalized?

@rekmarks rekmarks dismissed stale reviews from Gudahtt and whymarrh via a48ec51 June 15, 2020 18:55
@rekmarks
Copy link
Member Author

@Gudahtt, thanks for reminding me!

whymarrh
whymarrh previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd time's the charm 💫

@rekmarks
Copy link
Member Author

@whymarrh merge conflicts 😭

@rekmarks rekmarks merged commit a332c3e into develop Jun 15, 2020
@rekmarks rekmarks deleted the remove-the-word-dapp branch June 15, 2020 19:55
@metamaskbot
Copy link
Collaborator

Builds ready [c391291]
Page Load Metrics (854 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33145693215
domContentLoaded4471384852228110
load4491386854228110
domInteractive4471384851228109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@brad-decker brad-decker brad-decker left review comments

@whymarrh whymarrh whymarrh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rekmarks @metamaskbot @whymarrh @Gudahtt @brad-decker