Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor checkExistingAddresses #8868

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 29, 2020

This PR:

  • moves the checkExistingAddresses from ui/app/pages/add-token/util.js to ui/app/helpers/utils/util.js, because it is used in more than just ui/app/pages/add-token/
  • replaces the use of ramda in checkExistingAddresses with an ES .some call
  • renames some of the variables in checkExistingAddresses to generalize its purpose
  • adds unit tests for checkExistingAddresses

Note: This PR is in preparation of a forthcoming refactor of the add-token component

@danjm danjm requested a review from a team as a code owner June 29, 2020 14:48
@metamaskbot
Copy link
Collaborator

Builds ready [4cfd9f4]
Page Load Metrics (711 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3295542211
domContentLoaded6238637105828
load6248647115828
domInteractive6238637095828

@danjm danjm force-pushed the refactor-checkExistingAddresses branch from 4cfd9f4 to 5393926 Compare July 1, 2020 08:18
@danjm danjm force-pushed the refactor-checkExistingAddresses branch from 5393926 to fbd5d07 Compare July 1, 2020 08:26
@metamaskbot
Copy link
Collaborator

Builds ready [fbd5d07]
Page Load Metrics (675 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31114512311
domContentLoaded6237886743617
load6257906753617
domInteractive6237886733617

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit ac52557 into develop Jul 7, 2020
@Gudahtt Gudahtt deleted the refactor-checkExistingAddresses branch July 7, 2020 22:18
@Gudahtt Gudahtt mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants