Completes onboarding upon importing seed phrase #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
commented
Jun 30, 2020
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
Gudahtt
reviewed
Jul 2, 2020
There was a problem hiding this comment.
I noticed that completeOnboarding is still being called on the final page, so it's now called twice redundantly. It is still needed there for the "Create wallet" flow though I suppose, and calling completeOnboarding twice doesn't seem particularly harmful.
It would be nice to make this same change on the "Create wallet" flow though. Then this bug would be fixed for that flow as well, and we could remove the redundant completeOnboarding call.
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Outdated
Show resolved
Hide resolved
|
@Gudahtt - this is now done for the Create Account flow, and the now redundant call has been removed. |
Gudahtt
pushed a commit
that referenced
this pull request
Aug 7, 2020
Merged
Gudahtt
added a commit
that referenced
this pull request
Nov 10, 2020
The bug with our onboarding library integration was introduced in #8873 because of a change in when `completeOnboarding` was called. We hadn't realized at the time that the onboarding integration relied upon the onboarding completing event to know when the onboarding state should be cleared. Because onboarding is now marked as completed earlier, the state was cleared just as it was intended to be used. The onboarding completed event has been moved back to where it was before: after the user exits the "end of flow" page. The original problem that #8873 was addressing was a routing issue, where the user would be redirected back to the seed phrase confirmation page despite already having confirmed their seed phrase. This was fixed in a different way here, by updating the routing in the first time flow switch to skip straight to the end of flow page if the seed phrase has already been confirmed. This does involve one user-facing change in behavior; if the user opens any MetaMask UI before navigating away from the end-of-flow screen, they will still be considered mid-onboarding so it'll redirect to the end-of-flow screen. But we do mark onboarding as completed if the user closes the tab/window while on the end of flow screen, which was another goal of #8873.
Gudahtt
added a commit
that referenced
this pull request
Nov 10, 2020
The bug with our onboarding library integration was introduced in #8873 because of a change in when `completeOnboarding` was called. We hadn't realized at the time that the onboarding integration relied upon the onboarding completing event to know when the onboarding state should be cleared. Because onboarding is now marked as completed earlier, the state was cleared just as it was intended to be used. The onboarding completed event has been moved back to where it was before: after the user exits the "end of flow" page. The original problem that #8873 was addressing was a routing issue, where the user would be redirected back to the seed phrase confirmation page despite already having confirmed their seed phrase. This was fixed in a different way here, by updating the routing in the first time flow switch to skip straight to the end of flow page if the seed phrase has already been confirmed. This does involve one user-facing change in behavior; if the user opens any MetaMask UI before navigating away from the end-of-flow screen, they will still be considered mid-onboarding so it'll redirect to the end-of-flow screen. But we do mark onboarding as completed if the user closes the tab/window while on the end of flow screen, which was another goal of #8873.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8679
In the case we assume that the imported phrase is already backed up, onboarding should be completed so users can continue after closing out the "Congratulations!" page.
cc: @danfinlay