Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix language code format mismatch #8889

Merged
merged 1 commit into from
Jul 2, 2020
Merged

fix language code format mismatch #8889

merged 1 commit into from
Jul 2, 2020

Conversation

brad-decker
Copy link
Contributor

replace underscores with dashes to prevent bug resulting from Intl.RelativeTimeFormat expecting 'zh-CN' versus 'zh_CN'

see: https://sentry.io/share/issue/f2b717159e814ff7ba7331429b5850b4/

@brad-decker brad-decker requested a review from a team as a code owner July 2, 2020 19:57
Gudahtt
Gudahtt approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [7257f71]
Page Load Metrics (643 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint318543157
domContentLoaded3657856419546
load3667866439546
domInteractive3657846419546

@brad-decker brad-decker merged commit 68bcf38 into develop Jul 2, 2020
@brad-decker brad-decker deleted the fix-intl-rel-time branch July 2, 2020 20:13
@Gudahtt Gudahtt mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brad-decker @metamaskbot @Gudahtt