Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth-keyring-controller@6.0.1 #8897

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 2, 2020

Refs #8887

This update to eth-keyring-controller ensures that its memStore only updates once when the keyrings are unlocked.
This prevents the preferences controller from misclassifying identities belonging to keyrings other than the first as lost.

@metamaskbot
Copy link
Collaborator

Builds ready [f226e3a]
Page Load Metrics (626 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint328344178
domContentLoaded3537066259345
load3547086269345
domInteractive3527066249345

@rekmarks rekmarks force-pushed the lost-identities-on-unlock-fix branch 2 times, most recently from 5e78659 to eccbdf9 Compare July 2, 2020 23:56
@rekmarks rekmarks force-pushed the lost-identities-on-unlock-fix branch from eccbdf9 to fcdd0b9 Compare July 3, 2020 00:09
@rekmarks rekmarks marked this pull request as ready for review July 3, 2020 00:12
@rekmarks rekmarks requested a review from a team as a code owner July 3, 2020 00:12
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, though I don't quite follow how this fixes the bug.

@whymarrh
Copy link
Contributor

whymarrh commented Jul 3, 2020

I edited the "closes" to be "refs". I too don't believe that this closes that issue.

@metamaskbot
Copy link
Collaborator

Builds ready [fcdd0b9]
Page Load Metrics (841 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded472112783916780
load474112984116780
domInteractive472112783916780

@rekmarks rekmarks merged commit d3aa9f8 into develop Jul 3, 2020
@rekmarks rekmarks deleted the lost-identities-on-unlock-fix branch July 3, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants