Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace percentage opacity value #8898

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 3, 2020

The CSS opacity rule accepts percentages on newer browsers, but some older browser versions we support (e.g. Firefox v60) doesn't support them. A number is now used instead, which is supported by all browsers we support.

The CSS `opacity` rule accepts percentages on newer browsers, but some
older browser versions we support (e.g. Firefox v60) doesn't support
them. A number is now used instead, which is supported by all browsers
we support.
@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 3, 2020

Screenshot of problem:

With Firefox v60:
firefox60

After this change, it looks the same as on other browsers

@Gudahtt Gudahtt marked this pull request as ready for review July 3, 2020 00:34
@Gudahtt Gudahtt requested a review from a team as a code owner July 3, 2020 00:34
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [f74c006]
Page Load Metrics (610 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30100452311
domContentLoaded3586636096129
load3596656106129
domInteractive3576636086129

@Gudahtt Gudahtt merged commit 3832d69 into develop Jul 3, 2020
@Gudahtt Gudahtt deleted the replace-percentage-opacity-values branch July 3, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants