Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent confirming blank suggested token #8909

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Prevent confirming blank suggested token #8909

merged 1 commit into from
Jul 3, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 3, 2020

The "confirm suggested token" page allowed the confirm button to be pressed even when there were no tokens to confirm. This can happen sometimes when the page is in the process of redirecting.

@Gudahtt
Prevent confirming blank suggested token
7dc2b3b 
The "confirm suggested token" page allowed the confirm button to be
pressed even when there were no tokens to confirm. This can happen
sometimes when the page is in the process of redirecting.
@Gudahtt Gudahtt marked this pull request as ready for review July 3, 2020 15:53
@Gudahtt Gudahtt requested a review from a team as a code owner July 3, 2020 15:53
@metamaskbot
Copy link
Collaborator

Builds ready [7dc2b3b]
Page Load Metrics (643 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31103522512
domContentLoaded3827216417737
load3847236437737
domInteractive3827206417737

whymarrh
whymarrh approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit a4e7cff into develop Jul 3, 2020
@Gudahtt Gudahtt deleted the prevent-confirming-blank-suggested-token branch July 3, 2020 16:03
@Gudahtt Gudahtt mentioned this pull request Jul 3, 2020
Merged
@metamaskbot metamaskbot mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh