Fix display of incoming transactions #8942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `metamaskNetworkId` property in the `txMeta` for incoming transactions was incorrectly set as a Number instead of a String. This change was made accidentally as part of #8627. As a result incoming transactions were being excluded from the transaction list, as they didn't have a matching network ID. `metamaskNetworkId` is now set to a string, and a migration has been added to ensure `metamaskNetworkId` is converted to a string for any incoming transactions in state.
Builds ready [cb0f6a0]
Page Load Metrics (1347 ± 79 ms)
|
rekmarks
approved these changes
Jul 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
metamaskNetworkIdproperty in thetxMetafor incoming transactions was incorrectly set as a Number instead of a String. This change was made accidentally as part of #8627.As a result incoming transactions were being excluded from the transaction list, as they didn't have a matching network ID.
metamaskNetworkIdis now set to a string, and a migration has been added to ensuremetamaskNetworkIdis converted to a string for any incoming transactions in state.