Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint@6.8.0 #8978

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Use eslint@6.8.0 #8978

merged 2 commits into from
Jul 14, 2020

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Jul 14, 2020

Refs #8982

This PR updates our ESLint version to the latest v6 version, 6.8.0. This will reduce the noise of the upcoming ESLint config v2 work.

The comma-dangle rule was seemingly updated (fixed?) to apply to more places, hence the noise.

@whymarrh whymarrh marked this pull request as ready for review July 14, 2020 15:19
@whymarrh whymarrh requested review from kumavis and a team as code owners July 14, 2020 15:19
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Jul 14, 2020

The comma-dangle rule was seemingly updated (fixed?) to apply to more places, hence the noise.

To multi-line parameters in particular it seems. I had noticed it didn't enforce this before and thought it was intentional, but I guess not!

@whymarrh whymarrh merged commit 4f0a205 into MetaMask:develop Jul 14, 2020
@whymarrh whymarrh deleted the update-eslint branch July 14, 2020 15:20
@Gudahtt Gudahtt mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants