Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback-return issues #8996

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

whymarrh
Copy link
Contributor

Refs #8982

See callback-return for more information.

This change enables callback-return and fixes the resulting issues.

See [`callback-return`](https://eslint.org/docs/rules/callback-return) for more information.

This change enables `callback-return` and fixes the resulting issues.
@whymarrh whymarrh force-pushed the enable-callback-return branch from 88f6c94 to d9e468b Compare July 17, 2020 21:49
@whymarrh whymarrh marked this pull request as ready for review July 17, 2020 21:52
@whymarrh whymarrh requested a review from a team as a code owner July 17, 2020 21:52
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 68a64af into MetaMask:develop Jul 17, 2020
@whymarrh whymarrh deleted the enable-callback-return branch July 17, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants