Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guard-for-in issues #9000

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

whymarrh
Copy link
Contributor

Refs #8982

See guard-for-in for more information.

This change enables guard-for-in and fixes the issues raised by the rule.

@whymarrh whymarrh force-pushed the enable-guard-for-in branch from c94f575 to ca31723 Compare July 18, 2020 01:45
@whymarrh whymarrh marked this pull request as ready for review July 18, 2020 01:49
@whymarrh whymarrh requested a review from a team as a code owner July 18, 2020 01:49
@whymarrh whymarrh force-pushed the enable-guard-for-in branch from ca31723 to d22fc30 Compare July 20, 2020 15:02
brad-decker
brad-decker previously approved these changes Jul 20, 2020
@brad-decker
Copy link
Contributor

LGTM

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@whymarrh
Copy link
Contributor Author

(Thanks, I had rebased to get the build working.)

@whymarrh whymarrh merged commit bf6578c into MetaMask:develop Jul 21, 2020
@whymarrh whymarrh deleted the enable-guard-for-in branch July 21, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants