Skip render when home page is closing or redirecting #9012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon #9011 |
rekmarks
reviewed
Jul 16, 2020
|
Yep! It handles multiple permission requests and confirmations perfectly. Unfortunately it's broken in another way though; the "closing/redirecting" states are set on update, but the actual closing/redirecting only happens on mount. I'm updating it now to ensure the states are only set before mount. Edit: ^ This has now been fixed. |
Gudahtt
force-pushed
the
skip-render-while-home-page-closing-or-redirecting
branch
from
08a6869 to
58dddc1
Compare
Base automatically changed from
keep-notification-open-after-connect-if-confirmations-pending
to
develop
July 16, 2020 12:13
The Home page component is responsible for closing the notification window and triggering redirects in various situations. When this happens, the home page is briefly rendered before the redirect/close happens. This is a waste of cycles, and is distracting for users. We now render nothing if the page is in the process of redirecting or reloading. None of the redirects handled in this component are for sub- pages, so we don't need the Home page to render in any of these cases. We were already doing this for redirects to transaction confirmations, but now we're taking the same approach for all redirects, and for the cases where the window is closed.
Gudahtt
force-pushed
the
skip-render-while-home-page-closing-or-redirecting
branch
from
58dddc1 to
6f30472
Compare
Builds ready [6f30472]
Page Load Metrics (769 ± 62 ms)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Home page component is responsible for closing the notification window and triggering redirects in various situations. When this happens, the home page is briefly rendered before the redirect/close happens. This is a waste of cycles, and is distracting for users.
We now render nothing if the page is in the process of redirecting or reloading. None of the redirects handled in this component are for sub-pages, so we don't need the Home page to render in any of these cases.
We were already doing this for redirects to transaction confirmations, but now we're taking the same approach for all redirects, and for the cases where the window is closed.