Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear unapprovedTxs on createNewVaultAndRestore #9026

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Clear unapprovedTxs on createNewVaultAndRestore #9026

merged 2 commits into from
Jul 17, 2020

Conversation

tmashuang
Copy link
Contributor

Reported via support ticket with error in the screenshot.

Reproduction of the issue is:
Have an unapproved, waiting to be confirmed, and import a seed phrase via refreshing the extension.

Screenshot of the error

@tmashuang tmashuang requested a review from a team as a code owner July 16, 2020 23:52
Gudahtt
Gudahtt reviewed Jul 17, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we clear any unapproved transactions, instead of all transactions? It's just unapproved transactions specifically that are resulting in this bug. We don't need to clear all of the users tx history if they're just trying to reset their password.

@metamaskbot
Copy link
Collaborator

Builds ready [6019381]
Page Load Metrics (683 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32103512010
domContentLoaded3678576819947
load3698616839948
domInteractive3678576819947

@tmashuang tmashuang changed the title Clear transactions on createNewVaultAndRestore Clear unapprovedTxs on createNewVaultAndRestore Jul 17, 2020
Gudahtt
Gudahtt approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [985ec6c]
Page Load Metrics (605 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint288239188
domContentLoaded3966856035225
load4006876055225
domInteractive3966846035225

@tmashuang tmashuang merged commit 7b2218a into develop Jul 17, 2020
@tmashuang tmashuang deleted the clear-txs-on-import-seed branch July 17, 2020 01:37
@metamaskbot metamaskbot mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @metamaskbot @Gudahtt