Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-param-reassign issues #9235

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

whymarrh
Copy link
Contributor

Refs #8982

See no-param-reassign for more information.

This change enables no-param-reassign and fixes the issues raised by the rule.

@whymarrh whymarrh marked this pull request as ready for review August 14, 2020 17:25
@whymarrh whymarrh requested a review from a team as a code owner August 14, 2020 17:25
@whymarrh whymarrh requested a review from Gudahtt August 14, 2020 17:25
ui/app/pages/send/send.utils.js Show resolved Hide resolved
app/scripts/metamask-controller.js Outdated Show resolved Hide resolved
See [`no-param-reassign`](https://eslint.org/docs/rules/no-param-reassign) for more information.

This change enables `no-param-reassign` and fixes the issues raised by the rule.
@whymarrh whymarrh force-pushed the enable-no-param-reassign branch from 0ce7053 to de1c744 Compare August 14, 2020 20:21
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit e803807 into MetaMask:develop Aug 15, 2020
@whymarrh whymarrh deleted the enable-no-param-reassign branch August 15, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants