Skip to content

Commit 06ff8af

Browse files
authored
chore(predict): add transfer after claim (#22455)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - Adds minimum transfer after claim <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a balance check and optionally appends a USDC transfer to claim transactions when signer collateral is below a minimum threshold; updates claim transaction shape and tests. > > - **Polymarket Provider** > - `prepareClaim`: checks signer collateral via `getBalance` and sets `includeTransferTransaction` when balance < `MIN_COLLATERAL_BALANCE_FOR_CLAIM`. > - Returns claim `transactions` as an array (not a single object). > - **Safe Utils** > - `createClaimSafeTransaction`: optionally appends an ERC20 transfer (USDC) to the signer and aggregates via multisend. > - `getClaimTransaction`: accepts `includeTransferTransaction`, using signer address when true. > - **Constants** > - Introduces `MIN_COLLATERAL_BALANCE_FOR_CLAIM = 0.5` and uses collateral/decimals in transfer encoding. > - **Tests** > - Update provider and safe utils tests to expect array-based claim transactions and to cover transfer-inclusion cases across balance thresholds. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8abd446. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent c31e341 commit 06ff8af

File tree

5 files changed

+535
-45
lines changed

5 files changed

+535
-45
lines changed

0 commit comments

Comments
 (0)