-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(predict): add transfer after claim #22455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matallui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on updating the top-up calculations, but not blocking for this PR. We can address that later. 🚀
| value: parseUnits( | ||
| MIN_COLLATERAL_BALANCE_FOR_CLAIM.toString(), | ||
| COLLATERAL_TOKEN_DECIMALS, | ||
| ).toBigInt(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal should be to top up the account up to $1, not just add 0.5 when it's below that. I do think this is pretty good for this PR though, just to give something to Confirmations team. We can always update that logic later.
|




Description
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a balance check and optionally appends a USDC transfer to claim transactions when signer collateral is below a minimum threshold; updates claim transaction shape and tests.
prepareClaim: checks signer collateral viagetBalanceand setsincludeTransferTransactionwhen balance <MIN_COLLATERAL_BALANCE_FOR_CLAIM.transactionsas an array (not a single object).createClaimSafeTransaction: optionally appends an ERC20 transfer (USDC) to the signer and aggregates via multisend.getClaimTransaction: acceptsincludeTransferTransaction, using signer address when true.MIN_COLLATERAL_BALANCE_FOR_CLAIM = 0.5and uses collateral/decimals in transfer encoding.Written by Cursor Bugbot for commit 8abd446. This will update automatically on new commits. Configure here.