Commit 8ab1426
feat: cp-7.47.0 solana code fences (#15297)
## **Description**
- enables the Solana and Non-EVM code by moving the code fence flags to
the main set.
- this change makes all the Solana and Non-EVM features available in
main build.
> [!NOTE]
> The `keyring-snaps` is the code fence flag that allows for snaps like
the `solana`, `bitcoin`, any keyring snap to work, the Solana snap and
bitcoin snap are keyring-snaps.
> This code fence has all the broad/general code for non-evm snaps, and
then for specific network logic we have the solana, bitcoin etc...
## **Related issues**
Fixes: the current feature is under code fencing, only available in our
beta build, it has to be moved from beta to main set to be available in
the next release.
## **Manual testing steps**
```gherkin
Feature: Solana
Scenario: user opens new app install
Given the app is installed and wallet created
When user lands on wallet screen
Then user sees the new Solana feature announcement bottom sheet
And user sees in the accounts list "add Solana account"
And user sees in the network tab "Solana"
Scenario: user opens updated app
Given the app is updated with wallet already created
When user logs in
Then user sees the new Solana feature announcement bottom sheet
And user sees in the accounts list "add Solana account"
And user sees in the network tab "Solana"
```
## **Screenshots/Recordings**
### **Before**
#### Add account
<img width="340" alt="add account screenshot"
src="https://github.com/user-attachments/assets/2473cd0b-cfcd-4c4a-8f8e-73143e16315d"
/>
#### Select network
<img width="340" alt="select network screenshot"
src="https://github.com/user-attachments/assets/632f52cc-1013-4573-853d-178e372e220c"
/>
### **After**
#### New welcome bottom sheet
<img width="340" alt="new welcome modal screenshot"
src="https://github.com/user-attachments/assets/8124a0cd-e4b2-4daf-bdef-c08e7ff18516"
/>
#### Add account
<img width="340" alt="add account screenshot"
src="https://github.com/user-attachments/assets/5771e51a-6688-4d26-91df-7d7da622feba"
/>
#### Select network
<img width="340" alt="select network screenshot"
src="https://github.com/user-attachments/assets/54e3a06c-1d65-41dc-a2c2-eef8fb5a3c37"
/>
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
---------
Co-authored-by: António Regadas <antonio.regadas@consensys.net>
Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>1 parent ebce0f0 commit 8ab1426
File tree
6 files changed
+118
-6
lines changed- app/components/UI/SolanaNewFeatureContent
- e2e
- fixtures
- pages/wallet
- selectors/wallet
6 files changed
+118
-6
lines changedLines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| 136 | + | |
135 | 137 | | |
136 | 138 | | |
137 | 139 | | |
| |||
144 | 146 | | |
145 | 147 | | |
146 | 148 | | |
| 149 | + | |
147 | 150 | | |
148 | 151 | | |
149 | 152 | | |
150 | 153 | | |
151 | 154 | | |
152 | 155 | | |
153 | 156 | | |
| 157 | + | |
154 | 158 | | |
155 | 159 | | |
156 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
62 | 74 | | |
63 | 75 | | |
64 | 76 | | |
| |||
647 | 659 | | |
648 | 660 | | |
649 | 661 | | |
| 662 | + | |
650 | 663 | | |
651 | 664 | | |
652 | 665 | | |
| |||
758 | 771 | | |
759 | 772 | | |
760 | 773 | | |
761 | | - | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
762 | 777 | | |
763 | 778 | | |
764 | 779 | | |
| |||
870 | 885 | | |
871 | 886 | | |
872 | 887 | | |
873 | | - | |
| 888 | + | |
| 889 | + | |
874 | 890 | | |
875 | 891 | | |
876 | 892 | | |
| |||
910 | 926 | | |
911 | 927 | | |
912 | 928 | | |
913 | | - | |
| 929 | + | |
| 930 | + | |
914 | 931 | | |
915 | 932 | | |
916 | 933 | | |
| |||
961 | 978 | | |
962 | 979 | | |
963 | 980 | | |
964 | | - | |
| 981 | + | |
| 982 | + | |
965 | 983 | | |
966 | 984 | | |
967 | 985 | | |
| |||
976 | 994 | | |
977 | 995 | | |
978 | 996 | | |
| 997 | + | |
979 | 998 | | |
980 | | - | |
981 | 999 | | |
982 | 1000 | | |
983 | 1001 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
71 | 81 | | |
72 | 82 | | |
73 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
| |||
0 commit comments