Skip to content

Commit

Permalink
test: remove redundent tests in quarantine folder (#12556)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR aims to remove redundant e2e tests, specifically those in the
quarantine folder. The two tests that will be removed in this PR is:
- `import-nft.failing.js`:
- We already have test steps to import an NFT:
https://github.com/MetaMask/metamask-mobile/blob/main/e2e/specs/assets/nft-details.spec.js#L49#L52
   - `send-to-contact.failing.js`
        - We have multiple e2e tests that send funds to an address.  

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
cortisiko authored Dec 5, 2024
1 parent a93ef10 commit a907380
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 140 deletions.
7 changes: 6 additions & 1 deletion e2e/specs/assets/nft-details.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,14 @@ describe(SmokeAssets('NFT Details page'), () => {

await WalletView.tapNftTab();
await WalletView.scrollDownOnNFTsTab();
// Tap on the add collectibles button

await WalletView.tapImportNFTButton();
await Assertions.checkIfVisible(ImportNFTView.container);
await ImportNFTView.typeInNFTAddress('1234');
await ImportNFTView.typeInNFTIdentifier('');
await Assertions.checkIfVisible(ImportNFTView.addressWarningMessage);
//await ImportNFTView.tapBackButton();

await ImportNFTView.typeInNFTAddress(nftsAddress);
await ImportNFTView.typeInNFTIdentifier('1');

Expand Down
62 changes: 0 additions & 62 deletions e2e/specs/quarantine/import-nft.failing.js

This file was deleted.

77 changes: 0 additions & 77 deletions e2e/specs/quarantine/send-to-contact.failing.js

This file was deleted.

0 comments on commit a907380

Please sign in to comment.