temp+chore: cp-7.51.0 faster address checksum (#16926) (#17174)

## **Description**

This [PR](#16926) is
originally from @Nodonisko from Margelo

This PR uses new faster memoized functions for working with address
checksum.

There is already significant boost in AccountList performance and it
should be even better when MetaMask/core#6054 is
released and also when we fix Blockies Avatars.

## **Related issues**

Fixes: #15560

## **Manual testing steps**

1. Open Account List
2. It should feel faster than before

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
You can set that before then was lot of interrupted work before Account
List modal is even displayed. It takes around ~7s from click to modal to
be actually visible.

<img width="1324" alt="Screenshot 2025-07-03 at 21 36 06"
src="https://github.com/user-attachments/assets/7c624f31-db84-4ade-9df6-a116bff9a68f"
/>


### **After**

Here it takes only around ~3s to mount. (still slow but much better than
before)

<img width="1325" alt="Screenshot 2025-07-03 at 21 38 16"
src="https://github.com/user-attachments/assets/96a5a4f1-59b7-4cfa-b58c-ac84eb238654"
/>

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Daniel Suchý <suchydan@gmail.com>

Author: runway-github[bot]

.depcheckrc.yml

@@ -53,6 +53,7 @@ ignores:
   - 'improved-yarn-audit'
   - 'jetifier'
   - 'metro-react-native-babel-preset'
+  - 'octonode'
   - 'prettier-plugin-gherkin'
   - 'react-native-svg-asset-plugin'
   - 'regenerator-runtime'

.e2e.env.example

@@ -16,8 +16,3 @@ export USE_LOCAL_DAPP=true
 export MULTICHAIN_DAPP_URL="https://metamask.github.io/test-dapp-multichain/latest/"
 # Option 2: Use a custom remote URL
 # export MULTICHAIN_DAPP_URL="https://your-multichain-dapp.example.com/"
-
-# E2E prebuild paths
-export PREBUILT_IOS_APP_PATH='build/MetaMask.app'
-export PREBUILT_ANDROID_APK_PATH='build/MetaMask.apk'
-export PREBUILT_ANDROID_TEST_APK_PATH='build/MetaMask-Test.apk'

.github/CODEOWNERS

@@ -53,7 +53,6 @@ app/components/UI/Card/              @MetaMask/card
 
 # Confirmation Team
 app/components/Views/confirmations                          @MetaMask/confirmations
-app/components/Views/confirmations/external/staking          @MetaMask/confirmations @MetaMask/metamask-earn                
 app/core/Engine/controllers/approval-controller             @MetaMask/confirmations
 app/core/Engine/controllers/gas-fee-controller              @MetaMask/confirmations
 app/core/Engine/controllers/signature-controller            @MetaMask/confirmations

.github/workflows/stable-branch-sync.yml

@@ -144,9 +144,3 @@ github-tools/
 
 # API Monitor logs
 api-monitor-logs/
-
-# Claude AI development files
-CLAUDE.md
-/CLAUDE.md
-temp/
-/temp/

.gitignore

@@ -7,8 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- fix: Security vulnerability in RPC domain validation that could allow malicious domains to be misclassified as legitimate providers ([#17234](https://github.com/MetaMask/metamask-mobile/pull/17234))
-
 ## [7.50.1]
 
 ### Fixed

.storybook/storybook.requires.js

@@ -187,8 +187,8 @@ android {
         applicationId "io.metamask"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionName "7.50.1"
-        versionCode 2103
+        versionName "7.52.0"
+        versionCode 2149
         testBuildType System.getProperty('testBuildType', 'debug')
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         manifestPlaceholders.MM_BRANCH_KEY_TEST = "$System.env.MM_BRANCH_KEY_TEST"

CHANGELOG.md

@@ -8,7 +8,6 @@ import {
 } from './';
 import { wordlist } from '@metamask/scure-bip39/dist/wordlists/english';
 import { createMockInternalAccount } from '../../util/test/accountsControllerTestUtils';
-import { TraceName, TraceOperation } from '../../util/trace';
 import ReduxService from '../../core/redux/ReduxService';
 import { RootState } from '../../reducers';
 
@@ -29,12 +28,6 @@ const mockControllerMessenger = jest.fn();
 const mockAddDiscoveredAccounts = jest.fn();
 const mockGetAccountByAddress = jest.fn().mockReturnValue(mockExpectedAccount);
 
-// Mock for seedless onboarding
-const mockSelectSeedlessOnboardingLoginFlow = jest.fn();
-const mockAddNewSeedPhraseBackup = jest.fn();
-const mockTrace = jest.fn();
-const mockEndTrace = jest.fn();
-
 const hdKeyring = {
   getAccounts: () => {
     mockGetAccounts();
@@ -50,17 +43,6 @@ const mockSnapClient = {
   addDiscoveredAccounts: mockAddDiscoveredAccounts,
 };
 
-jest.mock('../../selectors/seedlessOnboardingController', () => ({
-  selectSeedlessOnboardingLoginFlow: (state: unknown) =>
-    mockSelectSeedlessOnboardingLoginFlow(state),
-}));
-
-jest.mock('../../util/trace', () => ({
-  ...jest.requireActual('../../util/trace'),
-  trace: (options: unknown) => mockTrace(options),
-  endTrace: (options: unknown) => mockEndTrace(options),
-}));
-
 const createMockState = (hasVault: boolean) => ({
   engine: {
     backgroundState: {
@@ -99,8 +81,7 @@ jest.mock('../../core/Engine', () => ({
       getAccountByAddress: () => mockGetAccountByAddress(),
     },
     SeedlessOnboardingController: {
-      addNewSeedPhraseBackup: (seed: Uint8Array, keyringId: string) =>
-        mockAddNewSeedPhraseBackup(seed, keyringId),
+      addNewSeedPhraseBackup: jest.fn().mockResolvedValue(undefined),
     },
   },
   setSelectedAddress: (address: string) => mockSetSelectedAddress(address),
@@ -122,11 +103,7 @@ describe('MultiSRP Actions', () => {
   describe('importNewSecretRecoveryPhrase', () => {
     it('imports new SRP', async () => {
       mockGetKeyringsByType.mockResolvedValue([]);
-      mockAddNewKeyring.mockResolvedValue({
-        getAccounts: () => [testAddress],
-        id: 'keyring-id-123',
-      });
-      mockSelectSeedlessOnboardingLoginFlow.mockReturnValue(false);
+      mockAddNewKeyring.mockResolvedValue({ getAccounts: () => [testAddress] });
 
       await importNewSecretRecoveryPhrase(testMnemonic);
 
@@ -154,74 +131,7 @@ describe('MultiSRP Actions', () => {
       expect(mockAddNewKeyring).not.toHaveBeenCalled();
     });
 
-    describe('seedless onboarding login flow', () => {
-      beforeEach(() => {
-        mockGetKeyringsByType.mockResolvedValue([]);
-        mockAddNewKeyring.mockResolvedValue({
-          getAccounts: () => [testAddress],
-          id: 'keyring-id-123',
-        });
-        mockSelectSeedlessOnboardingLoginFlow.mockReturnValue(true);
-      });
-
-      it('successfully adds seed phrase backup when seedless onboarding is enabled', async () => {
-        mockAddNewSeedPhraseBackup.mockResolvedValue(undefined);
-
-        const result = await importNewSecretRecoveryPhrase(testMnemonic);
-
-        expect(mockSelectSeedlessOnboardingLoginFlow).toHaveBeenCalled();
-        expect(mockTrace).toHaveBeenCalledWith({
-          name: TraceName.OnboardingAddSrp,
-          op: TraceOperation.OnboardingSecurityOp,
-        });
-        expect(mockAddNewSeedPhraseBackup).toHaveBeenCalledWith(
-          expect.any(Uint8Array),
-          'keyring-id-123',
-        );
-        expect(mockEndTrace).toHaveBeenCalledWith({
-          name: TraceName.OnboardingAddSrp,
-          data: { success: true },
-        });
-        expect(mockSetSelectedAddress).toHaveBeenCalledWith(testAddress);
-        expect(result.address).toBe(testAddress);
-        expect(mockAddDiscoveredAccounts).toHaveBeenCalled();
-      });
-
-      it('handles error when seed phrase backup fails and traces error', async () => {
-        mockAddNewSeedPhraseBackup.mockRejectedValue(
-          new Error('Backup failed'),
-        );
-
-        await expect(
-          async () => await importNewSecretRecoveryPhrase(testMnemonic),
-        ).rejects.toThrow('Backup failed');
-
-        expect(mockSelectSeedlessOnboardingLoginFlow).toHaveBeenCalled();
-        expect(mockTrace).toHaveBeenCalledWith({
-          name: TraceName.OnboardingAddSrp,
-          op: TraceOperation.OnboardingSecurityOp,
-        });
-        expect(mockAddNewSeedPhraseBackup).toHaveBeenCalledWith(
-          expect.any(Uint8Array),
-          'keyring-id-123',
-        );
-        expect(mockTrace).toHaveBeenCalledWith({
-          name: TraceName.OnboardingAddSrpError,
-          op: TraceOperation.OnboardingError,
-          tags: { errorMessage: 'Backup failed' },
-        });
-        expect(mockEndTrace).toHaveBeenCalledWith({
-          name: TraceName.OnboardingAddSrpError,
-        });
-        expect(mockEndTrace).toHaveBeenCalledWith({
-          name: TraceName.OnboardingAddSrp,
-          data: { success: false },
-        });
-      });
-    });
-
     it('calls addNewSeedPhraseBackup when seedless onboarding login flow is active', async () => {
-      mockAddNewSeedPhraseBackup.mockResolvedValue(undefined);
       mockGetKeyringsByType.mockResolvedValue([]);
       mockAddNewKeyring.mockResolvedValue({
         id: 'test-keyring-id',
@@ -234,10 +144,9 @@ describe('MultiSRP Actions', () => {
 
       await importNewSecretRecoveryPhrase(testMnemonic);
 
-      expect(mockAddNewSeedPhraseBackup).toHaveBeenCalledWith(
-        expect.any(Uint8Array),
-        'test-keyring-id',
-      );
+      expect(
+        Engine.context.SeedlessOnboardingController.addNewSeedPhraseBackup,
+      ).toHaveBeenCalledWith(expect.any(Uint8Array), 'test-keyring-id');
     });
   });
 

android/app/build.gradle

@@ -4,30 +4,22 @@ import ExtendedKeyringTypes from '../../constants/keyringTypes';
 import Engine from '../../core/Engine';
 import { KeyringSelector } from '@metamask/keyring-controller';
 import { InternalAccount } from '@metamask/keyring-internal-api';
-///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
+///: BEGIN:ONLY_INCLUDE_IF(solana)
 import {
   MultichainWalletSnapFactory,
   WalletClientType,
 } from '../../core/SnapKeyring/MultichainWalletSnapClient';
 ///: END:ONLY_INCLUDE_IF
-import {
-  ///: BEGIN:ONLY_INCLUDE_IF(solana)
-  SolScope,
-  ///: END:ONLY_INCLUDE_IF
-  ///: BEGIN:ONLY_INCLUDE_IF(bitcoin)
-  BtcScope,
-  ///: END:ONLY_INCLUDE_IF
-} from '@metamask/keyring-api';
 import {
   endPerformanceTrace,
   startPerformanceTrace,
 } from '../../core/redux/slices/performance';
 import { PerformanceEventNames } from '../../core/redux/slices/performance/constants';
 import { store } from '../../store';
+import { endTrace, trace, TraceName, TraceOperation } from '../../util/trace';
 import { getTraceTags } from '../../util/sentry/tags';
 
 import ReduxService from '../../core/redux';
-import { TraceName, TraceOperation, trace, endTrace } from '../../util/trace';
 import { selectSeedlessOnboardingLoginFlow } from '../../selectors/seedlessOnboardingController';
 
 export async function importNewSecretRecoveryPhrase(mnemonic: string) {
@@ -85,61 +77,26 @@ export async function importNewSecretRecoveryPhrase(mnemonic: string) {
     // on Error, wallet should notify user that the newly added seed phrase is not synced properly
     // user can try manual sync again (phase 2)
     const seed = new Uint8Array(inputCodePoints.buffer);
-    let addSeedPhraseSuccess = false;
     try {
-      trace({
-        name: TraceName.OnboardingAddSrp,
-        op: TraceOperation.OnboardingSecurityOp,
-      });
       await SeedlessOnboardingController.addNewSeedPhraseBackup(
         seed,
         newKeyring.id,
       );
-      addSeedPhraseSuccess = true;
     } catch (error) {
-      const errorMessage =
-        error instanceof Error ? error.message : 'Unknown error';
       // Log the error but don't let it crash the import process
-      console.error('Failed to backup seed phrase:', errorMessage);
-
-      trace({
-        name: TraceName.OnboardingAddSrpError,
-        op: TraceOperation.OnboardingError,
-        tags: { errorMessage },
-      });
-      endTrace({
-        name: TraceName.OnboardingAddSrpError,
-      });
-
-      throw error;
-    } finally {
-      endTrace({
-        name: TraceName.OnboardingAddSrp,
-        data: { success: addSeedPhraseSuccess },
-      });
+      console.error('Failed to backup seed phrase:', error);
     }
   }
 
   let discoveredAccountsCount = 0;
 
-  ///: BEGIN:ONLY_INCLUDE_IF(bitcoin)
-  const bitcoinMultichainClient = MultichainWalletSnapFactory.createClient(
-    WalletClientType.Bitcoin,
-  );
-  discoveredAccountsCount +=
-    await bitcoinMultichainClient.addDiscoveredAccounts(
-      newKeyring.id,
-      BtcScope.Mainnet,
-    );
-  ///: END:ONLY_INCLUDE_IF
-
   ///: BEGIN:ONLY_INCLUDE_IF(solana)
-  const solanaMultichainClient = MultichainWalletSnapFactory.createClient(
+  const multichainClient = MultichainWalletSnapFactory.createClient(
     WalletClientType.Solana,
   );
-  discoveredAccountsCount += await solanaMultichainClient.addDiscoveredAccounts(
+
+  discoveredAccountsCount = await multichainClient.addDiscoveredAccounts(
     newKeyring.id,
-    SolScope.Mainnet,
   );
   ///: END:ONLY_INCLUDE_IF