chore: cp-7.51.0 faster address checksum #16926
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Nodonisko
force-pushed
the
chore/faster-checksum
branch
from
6fc3deb to
997387c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tommasini
changed the title
Nodonisko
force-pushed
the
chore/faster-checksum
branch
from
997387c to
cd84603
Compare
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_fb25e5a0-d73d-4bd9-95e8-c5414c6c62f9). |
|
@Nodonisko this PR is failing on the linter and unit tests, can you take a look please? |
|
@tommasini Should be fixed in 3921518 |
Matt561
left a comment
Matt561
left a comment
There was a problem hiding this comment.
Approving 1 owned-file on behalf of Earn team ✅
Nodonisko
dismissed stale reviews from brianacnguyen, Matt561, and georgewrmarshall
via
05bc122
Nodonisko
dismissed stale reviews from georgewrmarshall and OGPoyraz
via
d0f3047
sethkfman
added
the
area-performance
|
@tommasini @gambinish @Matt561 @infiniteflower @vinistevam @georgewrmarshall Can I ask you guys again for approval? |
Cal-L
left a comment
Cal-L
left a comment
There was a problem hiding this comment.
LGTM - Merging into feature branch to run tests
Cal-L
merged commit 7fae5e5
into
MetaMask:margelo/faster-address-checksum
metamaskbot
added
the
release-7.52.0
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
22 similar comments
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
14 participants
Description
This PR uses new faster memoized functions for working with address checksum.
There is already significant boost in AccountList performance and it should be even better when MetaMask/core#6054 is released and also when we fix Blockies Avatars.
Related issues
Fixes: #15560
Manual testing steps
Screenshots/Recordings
Before
You can set that before then was lot of interrupted work before Account List modal is even displayed. It takes around ~7s from click to modal to be actually visible.
After
Here it takes only around ~3s to mount. (still slow but much better than before)
Pre-merge author checklist
Pre-merge reviewer checklist