Skip to content

Commit afdebf3

Browse files
authored
fix: margin bottom for android reveal srp (#17053)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR updates the styling for android to add additional margin bottom when revealing srp. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix bottom margin for android reveal srp ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MUL-349?atlOrigin=eyJpIjoiMzcwYmU0ZTkwYWFhNDg0NmIyYzBhZjJmODU3Yjg3YmYiLCJwIjoiaiJ9 ## **Manual testing steps** 1. Enable multichain accounts designs 2. On android go to account details 3. Go to reveal srp and see that there is additional margin. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** ![Screenshot_1752138617](https://github.com/user-attachments/assets/7852bbf4-a78b-4fc3-bbba-d40d4ef1d3ba) ![Simulator Screenshot - iPhone 15 Pro - 2025-07-10 at 17 08 36](https://github.com/user-attachments/assets/5261c8b9-2c93-4425-9c37-88e999588429) <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent e926bf7 commit afdebf3

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

app/components/Views/MultichainAccounts/AccountDetails/components/AccountInfo/AccountInfo.styles.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ const styleSheet = (params: { theme: Theme }) => {
1919
},
2020
copyAddress: {
2121
marginBottom: 16,
22-
padding: 8,
22+
paddingTop: 4,
23+
paddingBottom: 4,
24+
paddingLeft: 12,
25+
paddingRight: 12,
2326
gap: 4,
2427
borderRadius: 999,
2528
backgroundColor: colors.primary.muted,

app/components/Views/MultichainAccounts/sheets/RevealSRP/RevealSRP.styles.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ const styleSheet = (params: { vars: { insets: Insets } }) => {
3838
},
3939
buttonContainer: {
4040
marginTop: 'auto',
41+
marginBottom: Platform.OS === 'android' ? 12 : 0,
4142
paddingLeft: 16,
4243
paddingRight: 16,
4344
gap: 16,

app/components/Views/RevealPrivateCredential/__snapshots__/index.test.tsx.snap

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,10 @@ exports[`RevealPrivateCredential renders reveal private key correctly 1`] = `
11271127
"color": "#4459ff",
11281128
"gap": 4,
11291129
"marginBottom": 16,
1130-
"padding": 8,
1130+
"paddingBottom": 4,
1131+
"paddingLeft": 12,
1132+
"paddingRight": 12,
1133+
"paddingTop": 4,
11311134
},
11321135
]
11331136
}
@@ -1720,7 +1723,10 @@ exports[`RevealPrivateCredential renders with a custom selectedAddress 1`] = `
17201723
"color": "#4459ff",
17211724
"gap": 4,
17221725
"marginBottom": 16,
1723-
"padding": 8,
1726+
"paddingBottom": 4,
1727+
"paddingLeft": 12,
1728+
"paddingRight": 12,
1729+
"paddingTop": 4,
17241730
},
17251731
]
17261732
}

0 commit comments

Comments
 (0)