Skip to content

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jul 10, 2025

Description

This PR updates the styling for android to add additional margin bottom when revealing srp.

Changelog

CHANGELOG entry: fix bottom margin for android reveal srp

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-349?atlOrigin=eyJpIjoiMzcwYmU0ZTkwYWFhNDg0NmIyYzBhZjJmODU3Yjg3YmYiLCJwIjoiaiJ9

Manual testing steps

  1. Enable multichain accounts designs
  2. On android go to account details
  3. Go to reveal srp and see that there is additional margin.

Screenshots/Recordings

Before

After

Screenshot_1752138617
Simulator Screenshot - iPhone 15 Pro - 2025-07-10 at 17 08 36

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev requested a review from a team as a code owner July 10, 2025 09:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jul 10, 2025
@montelaidev montelaidev self-assigned this Jul 10, 2025
@montelaidev montelaidev added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. and removed team-accounts-framework Accounts Framework team labels Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8f0efcb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ba676e39-6ace-420e-bb7e-5f514a3e55cd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev enabled auto-merge July 10, 2025 09:26
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3502020
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/25be6406-bd52-41c0-8c7d-ebd2097822e2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev added this pull request to the merge queue Jul 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@montelaidev montelaidev added the team-accounts-framework Accounts Framework team label Jul 10, 2025
@montelaidev montelaidev enabled auto-merge July 10, 2025 13:39
@montelaidev montelaidev added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit afdebf3 Jul 10, 2025
61 of 71 checks passed
@montelaidev montelaidev deleted the fix/mul-349 branch July 10, 2025 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants