Skip to content

Commit b14fb58

Browse files
authored
fix: Revert "chore(runway): cherry-pick fix: fixes the network expansion tests (#17466)" (#17561)
This reverts commit 4402a42. Was cherry picked here: #17477 Error: e2e/specs/assets/token-detection-import-all.spec.ts(7,28): error TS2307: Cannot find module '../../framework/fixtures/FixtureBuilder' or its corresponding type declarations. Error: e2e/specs/assets/token-detection-import-all.spec.ts(8,30): error TS2307: Cannot find module '../../framework/fixtures/FixtureHelper' or its corresponding type declarations. ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
2 parents 360d01f + 235fa46 commit b14fb58

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

e2e/specs/assets/token-detection-import-all.spec.ts renamed to e2e/specs/assets/token-detection-import-all.spec.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
import { loginToApp } from '../../viewHelper';
33
import { SmokeNetworkAbstractions } from '../../tags';
44
import WalletView from '../../pages/wallet/WalletView';
5-
import Assertions from '../../framework/Assertions';
5+
import DetectedTokensView from '../../pages/wallet/DetectedTokensView';
6+
import Assertions from '../../utils/Assertions';
67
import TestHelpers from '../../helpers';
7-
import FixtureBuilder from '../../framework/fixtures/FixtureBuilder';
8-
import { withFixtures } from '../../framework/fixtures/FixtureHelper';
8+
import FixtureBuilder from '../../fixtures/fixture-builder';
9+
import { withFixtures } from '../../fixtures/fixture-helper';
910

1011
const ETHEREUM_NAME = 'Ethereum';
11-
const USDC_NAME = 'USDCoin';
12+
const USDC_NAME = 'USDC';
1213

1314
describe(SmokeNetworkAbstractions('Import all tokens detected'), () => {
1415
beforeAll(async () => {
@@ -25,12 +26,12 @@ describe(SmokeNetworkAbstractions('Import all tokens detected'), () => {
2526
async () => {
2627
await loginToApp();
2728

28-
await Assertions.expectElementToBeVisible(WalletView.container);
29+
await Assertions.checkIfVisible(WalletView.container);
2930
const eth = WalletView.tokenInWallet(ETHEREUM_NAME);
3031
const usdc = WalletView.tokenInWallet(USDC_NAME);
3132

32-
await Assertions.expectElementToBeVisible(eth);
33-
await Assertions.expectElementToBeVisible(usdc);
33+
await Assertions.checkIfVisible(eth);
34+
await Assertions.checkIfVisible(usdc);
3435
},
3536
);
3637
});

0 commit comments

Comments
 (0)