Skip to content

fix: Revert "chore(runway): cherry-pick fix: fixes the network expansion tests (#17466)" #17561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix: Revert "chore(runway): cherry-pick fix: fixes the network expansion tests (#17466)" #17561

merged 1 commit into from
Jul 24, 2025
+8 −7

Conversation

@Tyschenko
Copy link
Contributor

@Tyschenko Tyschenko commented Jul 24, 2025

This reverts commit 4402a42.

Was cherry picked here: #17477

Error: e2e/specs/assets/token-detection-import-all.spec.ts(7,28): error TS2307: Cannot find module '../../framework/fixtures/FixtureBuilder' or its corresponding type declarations.
Error: e2e/specs/assets/token-detection-import-all.spec.ts(8,30): error TS2307: Cannot find module '../../framework/fixtures/FixtureHelper' or its corresponding type declarations.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Tyschenko Tyschenko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team No E2E Smoke Needed labels Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 24, 2025
@Tyschenko
Copy link
Contributor Author

Tyschenko commented Jul 24, 2025

@metamaskbot update-attributions

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Tyschenko Tyschenko merged commit b14fb58 into release/7.52.0 Jul 24, 2025
59 of 61 checks passed
@Tyschenko Tyschenko deleted the release/revert_test_that_broke_lint branch July 24, 2025 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Sep 3, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

11 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 3, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 4, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tyschenko @metamaskbot @tommasini