Fix: update PPOM Validator to address blockaid performance issues (#7662

)
MetaMask · Nov 7, 2023 · c9322e4 · c9322e4
1 parent 541937e
commit c9322e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/app/core/Engine.ts b/app/core/Engine.ts
@@ -680,7 +680,8 @@ class Engine {
               AppConstants.NETWORK_STATE_CHANGE_EVENT,
               listener,
             ),
-          onPreferencesChange: () => undefined,
+          onPreferencesChange: (listener) =>
+            preferencesController.subscribe(listener),
           provider: networkController.getProviderAndBlockTracker().provider,
           ppomProvider: {
             PPOM,

diff --git a/package.json b/package.json
@@ -179,7 +179,7 @@
     "@metamask/network-controller": "^8.0.0",
     "@metamask/permission-controller": "^4.0.1",
     "@metamask/phishing-controller": "^3.0.0",
-    "@metamask/ppom-validator": "^0.7.0",
+    "@metamask/ppom-validator": "^0.10.0",
     "@metamask/preferences-controller": "^3.0.0",
     "@metamask/scure-bip39": "^2.1.0",
     "@metamask/sdk-communication-layer": "^0.10.1",

diff --git a/yarn.lock b/yarn.lock
@@ -3837,10 +3837,10 @@
     eth-phishing-detect "^1.2.0"
     punycode "^2.1.1"
 
-"@metamask/ppom-validator@^0.7.0":
-  version "0.7.0"
-  resolved "https://registry.yarnpkg.com/@metamask/ppom-validator/-/ppom-validator-0.7.0.tgz#04ebcbabf7d0eee5c703fa04447c875db9e31725"
-  integrity sha512-s0+u+2SQr47NIfrV6d3H2M8U0rMVsHt2u9okR1f7IW2OfgnOnOLnOMfwOHBHHvGdLh6ktcEsYy13J0ovwflnog==
+"@metamask/ppom-validator@^0.10.0":
+  version "0.10.0"
+  resolved "https://registry.yarnpkg.com/@metamask/ppom-validator/-/ppom-validator-0.10.0.tgz#1df0c1f983c1f4b65defd50870bcb88a0118e700"
+  integrity sha512-ivxh7GLxjkoMYvR40xBqRpTotI4aO+7dTogOnyq2jh4XGwueYxREJxkP5lF9aOlT3UFQf5Uu0KRJT1i+KCM9Tg==
   dependencies:
     "@metamask/base-controller" "^3.0.0"
     "@metamask/controller-utils" "^4.0.0"