Skip to content

Commit d1afa62

Browse files
authored
fix(card): cp-7.59.0 accept other chars on zip code input (#22635)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR solves the issue where users with alphanumeric ZIP/postal codes (such as those in the UK) are unable to complete the onboarding flow because the ZIP code field only accepts numeric input. The keyboard shown is numeric-only, and the field does not allow typing letters, preventing users from entering valid postal codes. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fix ZIP Code Input Blocks Letters on Card Onboarding flow ## **Related issues** Fixes: #22633 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="332" height="720" alt="image" src="https://github.com/user-attachments/assets/1a5056ed-225c-49f1-ac1a-f94a0162b15d" /> ### **After** <!-- [screenshots/recordings] --> <img width="332" height="720" alt="Simulator Screenshot - iPhone 16 - 2025-11-13 at 11 08 53" src="https://github.com/user-attachments/assets/26cb5338-e93c-485e-bcc6-51b7b447cf15" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Change `keyboardType` of the `zipCode` `TextField` in `PhysicalAddress.tsx` from `number-pad` to `default` to allow alphanumeric input. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6082943. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent ea8495b commit d1afa62

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/components/UI/Card/components/Onboarding/PhysicalAddress.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export const AddressFields = ({
185185
numberOfLines={1}
186186
size={TextFieldSize.Lg}
187187
value={zipCode}
188-
keyboardType="number-pad"
188+
keyboardType="default"
189189
maxLength={255}
190190
accessibilityLabel={strings(
191191
'card.card_onboarding.physical_address.zip_code_label',

0 commit comments

Comments
 (0)