Skip to content

Conversation

@Brunonascdev
Copy link
Contributor

@Brunonascdev Brunonascdev commented Nov 13, 2025

Description

This PR solves the issue where users with alphanumeric ZIP/postal codes (such as those in the UK) are unable to complete the onboarding flow because the ZIP code field only accepts numeric input. The keyboard shown is numeric-only, and the field does not allow typing letters, preventing users from entering valid postal codes.

Changelog

CHANGELOG entry: Fix ZIP Code Input Blocks Letters on Card Onboarding flow

Related issues

Fixes: #22633

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

image

After

Simulator Screenshot - iPhone 16 - 2025-11-13 at 11 08 53

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Change keyboardType of the zipCode TextField in PhysicalAddress.tsx from number-pad to default to allow alphanumeric input.

Written by Cursor Bugbot for commit 6082943. This will update automatically on new commits. Configure here.

@Brunonascdev Brunonascdev self-assigned this Nov 13, 2025
@Brunonascdev Brunonascdev requested a review from a team as a code owner November 13, 2025 14:09
@Brunonascdev Brunonascdev added the team-card Card Team label Nov 13, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Brunonascdev Brunonascdev changed the title fix(card): accept other chars on zip code input fix(card): cp-7.59.0 accept other chars on zip code input Nov 13, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Brunonascdev Brunonascdev added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Nov 13, 2025
@Brunonascdev Brunonascdev added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit d1afa62 Nov 13, 2025
158 of 163 checks passed
@Brunonascdev Brunonascdev deleted the fix/mm-card-onboarding-zip-code-input-letters branch November 13, 2025 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-XS skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-card Card Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Card Onboarding Flow: ZIP Code Input Blocks Letters, Preventing UK Users from Proceeding

4 participants