More tests for providerRequestsCount

MetaMask · Oct 13, 2023 · ef3efb7 · ef3efb7
1 parent 8578eb0
commit ef3efb7
Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/app/components/UI/BlockaidBanner/BlockaidBanner.types.ts b/app/components/UI/BlockaidBanner/BlockaidBanner.types.ts
@@ -31,7 +31,7 @@ export interface SecurityAlertResponse {
   reason: Reason;
   features: string[];
   resultType: ResultType;
-  providerRequestsCount: Record<string, number>;
+  providerRequestsCount?: Record<string, number>;
 }
 
 type BlockaidBannerAllProps = BannerAlertProps & {

diff --git a/app/util/blockaid/index.test.ts b/app/util/blockaid/index.test.ts
@@ -31,4 +31,36 @@ describe('getBlockaidMetricsParams', () => {
       ppom_eth_getCode_count: 3,
     });
   });
+
+  it('should not return eth call counts if providerRequestsCount is empty', () => {
+    const securityAlertResponse: SecurityAlertResponse = {
+      resultType: ResultType.Malicious,
+      reason: Reason.notApplicable,
+      features: [],
+      providerRequestsCount: {},
+    };
+
+    const result = getBlockaidMetricsParams(securityAlertResponse);
+    expect(result).toEqual({
+      ui_customizations: ['flagged_as_malicious'],
+      security_alert_response: ResultType.Malicious,
+      security_alert_reason: Reason.notApplicable,
+    });
+  });
+
+  it('should not return eth call counts if providerRequestsCount is undefined', () => {
+    const securityAlertResponse: SecurityAlertResponse = {
+      resultType: ResultType.Malicious,
+      reason: Reason.notApplicable,
+      features: [],
+      providerRequestsCount: undefined,
+    };
+
+    const result = getBlockaidMetricsParams(securityAlertResponse);
+    expect(result).toEqual({
+      ui_customizations: ['flagged_as_malicious'],
+      security_alert_response: ResultType.Malicious,
+      security_alert_reason: Reason.notApplicable,
+    });
+  });
 });