Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Approve an ERC721 token displays as ERC20 token as the contract name fallback #6273

Closed
seaona opened this issue Apr 26, 2023 · 2 comments
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-confirmations-planning (only for internal use within Confirmations team) type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Apr 26, 2023

Describe the bug
Whenever we are approving an ERC721 token, if we go to the Verify third party details, we can see how the token address displays a fallback name of ERC20 Token. This is not correct.

Screenshots

mobile-approve-erc721-erc20.webm

To Reproduce
Steps to reproduce the behavior

  1. Go to the test dapp https://metamask.github.io/test-dapp/
  2. Deploy Collectibles contract
  3. Mint a token
  4. Click approve
  5. Click Verify Third party details
  6. See how the token contract displays ERC20 Token as the address name

Expected behavior
Not sure if we should see here only the address, or a fallback with ERC721 token. What do you think @bschorchit ?

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: android
  • App Version: 6.5.0

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Apr 26, 2023
@hilvmason hilvmason added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jun 5, 2023
@bschorchit bschorchit added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Aug 29, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Nov 27, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-confirmations-planning (only for internal use within Confirmations team) type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants