[Bug] Verify third party details causes to watch the asset undesirably #7178
Comments
seaona
added
type-bug
seaona
changed the title
bschorchit
added
the
Sev2-normal
|
Hey @seaona, I think we should separate this issue into two different issues? Wdyt? The first should fix the bug that adds the token when only trying to verify third party details. We have a fix here. It prevents calling The second issue should then enable watching erc721 token on mobile which I don't think we currently support. PS: [Bug] Approve an ERC721 token displays as ERC20 token as the contract name fallback is fixed here |
|
hi @blackdevelopa thanks for your comment, this makes sense to me 👍 About the second issue;
I think adding support to watch ERC721 falls under Mobile Core team, so I think we can leave that part outside Confirmations scope. cc @bschorchit |
…#7410) ## **Description** When approving a token and you click on `Verify third party details` it adds the token to the wallet. This PR prevents calling `addToken` on the token approve screen. ## **Manual testing steps** 1. Go to the test dapp 2. Deploy an ERC721/ERC20 token 3. Click Approve 4. Click Verify Third party details 5. Cancel 6. Go to the Home wallet 7. You shouldn't see a new token added to your wallet. ## **Screenshots/Recordings** _If applicable, add screenshots and/or recordings to visualize the before and after of your change._ Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e072c203-f63d-4115-bf86-768408fe083e ### **Before** https://github.com/MetaMask/metamask-mobile/assets/54408225/00e92cf0-948f-47d4-bb7a-b604d361279d ### **After** https://github.com/MetaMask/metamask-mobile/assets/29962968/cba721d4-8b69-49f9-a1ae-ed22f1fa7ad4 ## **Related issues** _Fixes #7178 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Describe the bug
Whenever you are Approving a token, if you click on
Verify third party detailsthe following behaviour happens:ERC20 Tokenwhich is incorrect ,and seems related to this other bug [Bug] Approve an ERC721 token displays asERC20 tokenas the contract name fallback #6273Screenshots
verify-3rd-party-details.mp4
To Reproduce
ERC20 tokenis now added to your walletExpected behavior
My expectation would be that no token is added at all, whenever we check the third party details.
In case it's added, it should be added correctly (under NFTs) and with the correct name, not ERC20
Smartphone (please complete the following information):
to be added after bug submission by internal support / PM
Severity
The text was updated successfully, but these errors were encountered: