-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Verify third party details causes to watch the asset undesirably #7410
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7410 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 1017 1017
Lines 27162 27161 -1
Branches 2211 2211
=======================================
Hits 9402 9402
+ Misses 17273 17272 -1
Partials 487 487
☔ View full report in Codecov by Sentry. |
hey @blackdevelopa the PR looks good from QA, I see the issue fixed 🔥 watch-asset-fixed.mp4 |
Kudos, SonarCloud Quality Gate passed! |
Description
When approving a token and you click on
Verify third party details
it adds the token to the wallet. This PR prevents callingaddToken
on the token approve screen.Manual testing steps
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e072c203-f63d-4115-bf86-768408fe083e
Before
verify-3rd-party-details.mp4
After
Screen.Recording.2023-10-06.at.18.25.05.mov
Related issues
_Fixes #7178
Pre-merge author checklist
Pre-merge reviewer checklist