Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PPOM - Error trying to initialize PPOM when opening wallet #7775

Closed
seaona opened this issue Nov 13, 2023 · 3 comments · Fixed by #7788
Closed

[Bug]: PPOM - Error trying to initialize PPOM when opening wallet #7775

seaona opened this issue Nov 13, 2023 · 3 comments · Fixed by #7788
Assignees
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Nov 13, 2023

Describe the bug

Problem: whenever I am loading the wallet for the first time, or opening the wallet, I see the error Error trying to initialize PPOM.

The error started appearing after this PR c9322e4

Expected behavior

No error should appear.
Blockaid should work

Screenshots/Recordings

Screenshot from 2023-11-13 12-51-59

Screenshot from 2023-11-13 12-52-06

Steps to reproduce

  1. Build the wallet with blockaid feature flag enabled
  2. Open the wallet
  3. See error

Error messages or log output

No response

Version

develop (with blockaid feature flag on)

Build type

None

Device

Pixel 6

Operating system

Android

Additional context

No response

Severity

No response

@seaona seaona added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Nov 13, 2023
@jpuri
Copy link
Contributor

jpuri commented Nov 13, 2023

This error can be ignored for some reason in react native this error is encountered, as I understand it will be visible only in dev mode. Blockaid validations will continue to work well.

In coming releases of PPOMController we will remove this log also.

@jpuri
Copy link
Contributor

jpuri commented Nov 13, 2023

Blockaid is working for me in latest code from main branch.

Private Zenhub Video

@seaona
Copy link
Contributor Author

seaona commented Nov 13, 2023

@jpuri I've removed the loading issue from this ticket, since we agreed it's a separate issue. I'll open a different ticket for that

@seaona seaona changed the title [Bug]: Error trying to initialize PPOM when opening wallet [Bug]: PPOM - Error trying to initialize PPOM when opening wallet Nov 13, 2023
@jpuri jpuri self-assigned this Nov 13, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants