Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB] Replace SheetBottom with BottomSheet in AccountPermission #8424

Closed
brianacnguyen opened this issue Jan 29, 2024 · 0 comments · Fixed by #8441
Closed

[MOB] Replace SheetBottom with BottomSheet in AccountPermission #8424

brianacnguyen opened this issue Jan 29, 2024 · 0 comments · Fixed by #8441
Assignees
@brianacnguyen
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-design-system All issues relating to design system in Mobile

Comments

@brianacnguyen
Copy link
Contributor

brianacnguyen commented Jan 29, 2024 •
edited
Loading

Replace SheetBottom with BottomSheet in AccountPermission
@brianacnguyen brianacnguyen added INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-design-system All issues relating to design system in Mobile labels Jan 29, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 29, 2024
@brianacnguyen brianacnguyen changed the title Copy of [MOB] Replace SheetBottom with BottomSheet in AccountConnect [MOB] Replace SheetBottom with BottomSheet in AccountPermission Jan 29, 2024
@brianacnguyen brianacnguyen mentioned this issue Jan 29, 2024
Merged
13 tasks
brianacnguyen added a commit that referenced this issue Jan 30, 2024
@brianacnguyen
refactor: Replace SheetBottom with BottomSheet in AccountsPermission (#…

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
GPG key ID: DA17C4B29CB32E4B
Verified
Learn about vigilant mode
Loading
Loading status checks…
9b690b7 
…8441)

## **Description**
Replace SheetBottom with BottomSheet in AccountsPermission

## **Related issues**

Fixes: #8424 

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianacnguyen brianacnguyen

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Replace SheetBottom with BottomSheet in AccountsPermission MetaMask/metamask-mobile
2 participants
@brianacnguyen @metamaskbot