fix(deps): bump @metamask/composable-controller from ^3.0.0 to ^6.0.2

[MajorLift]

Description

• Applies ComposableController API changes introduced to the controller in the following series of PRs:

  • Upgrade ComposableController to extend BaseControllerV2 core#3590 (v5.0.0)
  • [composable-controller] Better typing for state, messenger, strict type checks for inputs, remove #controllers field core#3904 (v6.0.0)
  • [composable-controller] Subscribe to stateChange events of V1 controllers with messenger, type fixes core#3964 (v6.0.0)
  • [composable-controller] Narrow class and messenger types by parameterizing over child controllers list core#3952 (v6.0.2)

• Provides hotfix for type error caused by mismatch between the ControllerInstance generic constraint to the ChildControllers generic parameter of the ComposableController class.

  • As long as we're confident about the accuracy of the Controllers type, it should be safe to apply this @ts-expect-error, since we're overloading the ChildControllers generic parameter with known information about the input child controllers (Controllers[keyof Controllers]).

Required follow-up changes

• ComposableController:

  • The BaseControllerV1Instance type needs to be fixed to accommodate controller versions used in mobile that inherit from BaseControllerV1.

  Type 'PhishingController | AccountsController | AccountTrackerController | AddressBookController | ... 22 more ... | SwapsController' does not satisfy the constraint 'ControllerInstance'.
  Type 'AccountTrackerController' is not assignable to type 'ControllerInstance'.
    Type 'AccountTrackerController' is not assignable to type 'BaseControllerV1Instance'.
      Types have separate declarations of a private property 'initialConfig'.ts(2344)

  • Add jsdoc for the ChildControllers optional generic parameter, making it clearer that a full list of controllers can be supplied by the consumer.
  • Fix LegacyComposableControllerStateConstraint to { [name: string]: Record<any, any> }, since index signature of interface types used for V1 state objects is not fixed to string.
  • Test on mobile engine whether runtime checks isBaseController() and isBaseControllerV1() are functioning as intended.

• On mobile, upgrade the affected controllers to V2:

  • V2 upgrades are available for all of the following:
    • AccountTrackerController
    • NftController
    • TokenRatesController
    • TransactionController
  • Exceptions:
    • AssetsContractController: set to be upgraded to non-controller that uses messenger but doesn't inherit from BaseControllerV2. ComposableController will need to be updated to accommodated non-controllers
    • NftDetectionController: current release inherits from BaseControllerV2, but should be upgraded to non-controller.
    • SwapsController: V2 upgrade unavailable

Related issues

• Resolves issues found in @kylanhurt's branch: main...kylan/composable-controller
• Blocked by https://github.com/metamask/metamask-mobile/10073

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[MajorLift]

We're seeing an error on this line that requires the following hotfix:
Remove the ControllerInstance generic constraint from the ChildControllers generic parameter of ComposableController.

Fundamentally, the ControllerInstance type needs to be fixed so that BaseControllerV1 instances are assignable.

[MajorLift]

Superseded by:

• [composable-controller] Fix incorrect behavior and improve type-level safeguards core#4467
• [DNM] Preview branch of complete ComposableController fix with no type error suppression #10374