[DNM] Preview branch of complete `ComposableController` fix with no type error suppression#10374

Closed

MajorLift wants to merge 22 commits intoupgrade-yarn-to-v3from bump-composable-controller-from-3.0.0-to-8.0.0

+649-237

Commits on Aug 1, 2024

Pin yarn resolution for @metamask/base-controller to 6.0.2
MajorLift
committed
Remove all @ts-{expect-error,ignore} directives on base-controller version mismatch errors
MajorLift
committed
Fix PPOMController outdated base-controller version and missing stateChange event
MajorLift
committed
Bump @metamask/assets-controllers from ^30.0.0 to ^37.0.0 to resolve import issues
MajorLift
committed
Update controller state types that have been renamed
MajorLift
committed
Fix TokenBalancesController:stateChange error, add TokenBalancesController{Actions,Events} to Global{Actions,Events}
MajorLift
committed
Fix name property missing from AssetsContractController
MajorLift
committed
Add AccountTrackerController, TokenRatesController actions/events to Global{Actions,Events}
MajorLift
committed
Fix AddressBookController:stateChange error by updating to new package version that inherits from BaseControllerV2 and registering to Global{Actions,Events}
MajorLift
committed
Fix TransactionController:stateChange error by updating to new package version that inherits from BaseControllerV2 and registering to Global{Actions,Events}
MajorLift
committed
Fix NftController:stateChange error by registering to Global{Actions,Events}
MajorLift
committed
Fix SnapsRegistry:stateChange error by creating yarn patch that exports missing stateChange type
MajorLift
committed
Fix PhishingController:stateChange error by creating yarn patch that exports missing stateChange type
MajorLift
committed
Fix NotificationServicesController:stateChange error by creating yarn patch that exports missing stateChange type
MajorLift
committed
Fix {Authentication,UserStorage}Controller:stateChange error by creating yarn patch that exports missing stateChange type
MajorLift
committed
Fix LoggingController:stateChange error by creating yarn patch that exports missing stateChange type
MajorLift
committed
Consolidate comments on ComposableController events allowlist
MajorLift
committed
Apply core PR: "Move composable-controller utility types to base-controller"
MajorLift
committed
Add logic for excluding non-controllers from child controllers passed into ComposableController
MajorLift
committed
Remove non-controllers from EngineState
MajorLift
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DNM] Preview branch of complete `ComposableController` fix with no type error suppression#10374

Commits on Aug 1, 2024

Pin yarn resolution for `@metamask/base-controller` to `6.0.2`

Remove all `@ts-{expect-error,ignore}` directives on base-controller version mismatch errors

Fix `PPOMController` outdated base-controller version and missing `stateChange` event

Bump `@metamask/assets-controllers` from `^30.0.0` to `^37.0.0` to resolve import issues

Update controller state types that have been renamed

Fix `TokenBalancesController:stateChange` error, add `TokenBalancesController{Actions,Events}` to `Global{Actions,Events}`

Fix `name` property missing from `AssetsContractController`

Add `AccountTrackerController`, `TokenRatesController` actions/events to `Global{Actions,Events}`

Fix `AddressBookController:stateChange` error by updating to new package version that inherits from `BaseControllerV2` and registering to `Global{Actions,Events}`

Fix `TransactionController:stateChange` error by updating to new package version that inherits from `BaseControllerV2` and registering to `Global{Actions,Events}`

Fix `NftController:stateChange` error by registering to `Global{Actions,Events}`

Fix `SnapsRegistry:stateChange` error by creating yarn patch that exports missing `stateChange` type

Fix `PhishingController:stateChange` error by creating yarn patch that exports missing `stateChange` type

Fix `NotificationServicesController:stateChange` error by creating yarn patch that exports missing `stateChange` type

Fix `{Authentication,UserStorage}Controller:stateChange` error by creating yarn patch that exports missing `stateChange` type

Fix `LoggingController:stateChange` error by creating yarn patch that exports missing `stateChange` type

Consolidate comments on ComposableController events allowlist

Apply core PR: "Move composable-controller utility types to base-controller"

Add logic for excluding non-controllers from child controllers passed into `ComposableController`

Remove non-controllers from `EngineState`

Commits on Aug 2, 2024

Revert "Remove non-controllers from `EngineState`"

Exclude non-controllers from the type argument for the `ComposableControllerState` generic parameter