Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flipper pod compilation with pika 15.3 toolchain #11080

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

joaoloureirop
Copy link
Contributor

@joaoloureirop joaoloureirop commented Sep 6, 2024

add pod post install script to include required import
see more facebook/flipper@b3dcdb8
facebook/react-native#43335 (comment)

NOTE: to install ios pods run yarn pod:install. It will execute bundle exec pod install --project-directory=ios within the project root directory.
Running pod install inside ios folder will error out

add pod post install script to include required import
see more facebook/flipper@b3dcdb8
@joaoloureirop joaoloureirop added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 6, 2024
@joaoloureirop joaoloureirop self-assigned this Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop marked this pull request as ready for review September 6, 2024 10:44
@joaoloureirop joaoloureirop requested a review from a team as a code owner September 6, 2024 10:44
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 6, 2024
Copy link

sonarcloud bot commented Sep 6, 2024

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Works like a charm.

@joaoloureirop joaoloureirop merged commit 976e7f4 into main Sep 6, 2024
37 checks passed
@joaoloureirop joaoloureirop deleted the fix/flipper-pod-pika-toolchain branch September 6, 2024 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.31.0 Issue or pull request that will be included in release 7.31.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants