Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-841 build unstake review confirmation screen #11611

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Oct 3, 2024

Description

Adds the unstaking confirmation screen. The screen is temporarily using mock data for certain elements.

Related issues

  • STAKE-841: [FE] Build unstake review confirmation screen - (link)

Manual testing steps

  1. Add export MM_POOLED_STAKING_UI_ENABLED=true to your .js.env file.
  2. Click on Ethereum In the token list page
  3. Click on "Staked Ethereum" Balance row
  4. The Unstaking Confirmation screen should appear.

Note: Attaching the unstaking confirmation screen to the "Staked Ethereum" asset row is temporary in order to view the screen. The unstaking confirmation screen will be added to the unstaking flow when it's dependent screen(s) have been completed.

Screenshots/Recordings

Before

N/A - This is a new screen

After

stake-841-build-unstake-review-confirmation-screen-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 changed the title DO NOT MERGE - feat: STAKE-841 build unstake review confirmation screen feat: STAKE-841 build unstake review confirmation screen Oct 21, 2024
@Matt561 Matt561 marked this pull request as ready for review October 21, 2024 16:37
@Matt561 Matt561 requested review from a team as code owners October 21, 2024 16:37
@Matt561
Copy link
Contributor Author

Matt561 commented Oct 21, 2024

Update

I've removed the "Gas fee" card from the review screen

image

@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 08fa379
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b68b445-f052-4dc0-b27f-9b466f2f8f0d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes required due to updated components and hooks .

@Matt561 Matt561 force-pushed the feat/stake-841-build-unstake-review-confirmation-screen branch from 1f41801 to f8edfa2 Compare October 22, 2024 21:12
@Matt561 Matt561 force-pushed the feat/stake-841-build-unstake-review-confirmation-screen branch from e73a691 to 3d2252e Compare October 22, 2024 21:17
@Matt561 Matt561 removed the request for review from a team October 22, 2024 21:17
@Matt561 Matt561 force-pushed the feat/stake-841-build-unstake-review-confirmation-screen branch from 3d2252e to daaa252 Compare October 22, 2024 21:18
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: daaa252
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/49a44d41-ed03-4ada-aa55-7a5be0b72cdd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants