Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2804): Right margin was to wide and looked broken compared to left #11767

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Oct 11, 2024

Description

This fixes the right margin of the modal that shows when switching network

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2796

Manual testing steps

I have added screenshot below to see how it looks.

  1. Go to the in-app brower on the mobile wallet, connect to a dapp like uniswap
  2. Switch netowrk to a network for which permission was not added before
  3. A modal will show up and show have the same margin width on the right side as on the left side.

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18s at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Oct 11, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 marked this pull request as ready for review October 11, 2024 21:56
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner October 11, 2024 21:56
@EtherWizard33 EtherWizard33 mentioned this pull request Oct 11, 2024
7 tasks
@EtherWizard33 EtherWizard33 changed the title fix(2804): Right margin was to wide and looked broken compared to left… fix(2804): Right margin was to wide and looked broken compared to left Oct 11, 2024
…argin fixed.

Confirmed all usages of the NetworkVerification component render well as well after this right margin fix.
…workVerificationInfo, since networkswitcher calls custom network who calls network modal who called network verification info
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 18, 2024
@EtherWizard33 EtherWizard33 requested review from a team as code owners October 18, 2024 18:43
Copy link
Contributor

github-actions bot commented Oct 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cb7207a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28158468-4667-490b-9b75-5191d4cc4c76

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a615305
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ed3fdac-e6ad-40d8-a17d-77d7d6267a4a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant