Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release action to not create the release branch but just open PR #11842

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Oct 17, 2024

Description

This PR makes a minor change to make the release action depend on an existing release branch before running the action. The new action will create a PR for the release branch and creating a PR for the changelog and version bump against the release branch.

Related issues

Fixes:

Manual testing steps

  1. Confirm there is a release branch
  2. Run the GH action
  3. See successful run and 2 PRs

Screenshots/Recordings

Before

NA

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform and removed team-mobile-delivery labels Oct 17, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

@sethkfman sethkfman linked an issue Oct 18, 2024 that may be closed by this pull request
9 tasks
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NicolasMassart NicolasMassart added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 7d4577f Oct 21, 2024
42 of 43 checks passed
@NicolasMassart NicolasMassart deleted the chore/remove-branch-creation-on-release-branch branch October 21, 2024 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub: Update create release GH action
3 participants