chore(runway): cherry-pick fix: migrate from decommissioned ipfs gateway to new one #12032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=60&v=4){kind=small}
…way to new one (#11985) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - adds state migration for users with decommissioned IPFS gateway - adds migration tests - adds new target gateway (dweb.link) to list and make it replace decommissioned gateway. >[!NOTE] > this is only a state migration, the user will not have any visible warnings. It will only show the new gateway as selected instead of the decommissioned one if it was in their state. ## **Related issues** Fixes #11692 ## **Manual testing steps** ```gherkin Feature: Migrate from decommissioned gateway to dweb.link Scenario: Verify non migrated gateway Given an installed app that was built before the decommission of https://cloudflare-ipfs.com/ipfs/ (pre ac79785, for latest is 7.32.0) When go to security & privacy settings And select https://cloudflare-ipfs.com/ipfs/ Then see "Your current IPFS gateway is down" as decommissioned gateway does not respond Scenario: Check migration Given the current PR app installed When go to security & privacy settings Then see "https://dweb.link/ipfs/" gateway selected ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 22 00 21 <img src="https://github.com/user-attachments/assets/f1e9ddc5-d40c-4726-9ad9-222dcaedf8aa" width="300px"/> ### **After** Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 22 15 31 <img src="https://github.com/user-attachments/assets/090cfbed-1e20-4cf1-8f4f-8fa2f1f1bcd8" width="300px"/> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
NicolasMassart
approved these changes
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
decommissioned gateway.
Note
this is only a state migration, the user will not have any visible
warnings. It will only show the new gateway as selected instead of the
decommissioned one if it was in their state.
Related issues
Fixes #11692
Manual testing steps
Screenshots/Recordings
Before
Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 22 00 21
After
Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 22 15 31
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Co-authored-by: legobeat 109787230+legobeat@users.noreply.github.com
Co-authored-by: tommasini 46944231+tommasini@users.noreply.github.com 9b8599e