Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix block explorer return button #12036

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 26, 2024

Description

After trying to add a block explorer the Add Custom Network modal pops-up. I am adding block explorer by using device keypad enter button because the Add Block Explorer URL button is not reachable, keypad in the way. May be because of the keypad that is causing this.

Have not been able to successfully add a block explorer.

Related issues

Fixes: #11992

Manual testing steps

  1. Go to add network form
  2. fill the form
  3. when you fill the block explorer form click on return keyboard button

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
@salimtb salimtb self-assigned this Oct 28, 2024
@salimtb salimtb marked this pull request as ready for review October 28, 2024 08:21
@salimtb salimtb requested review from a team as code owners October 28, 2024 08:21
Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ce1c8ea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/35833ab4-2c26-4ed4-98d9-6af4fe1c047f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added the regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 label Oct 28, 2024
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@salimtb salimtb added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 9f10685 Oct 28, 2024
53 of 54 checks passed
@salimtb salimtb deleted the salim/fix-enter-button-block-explorer-form branch October 28, 2024 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Adding block explorer shows Add Custom Network modal
3 participants