Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate chain before send #12048

Merged
merged 6 commits into from
Oct 28, 2024
Merged

fix: validate chain before send #12048

merged 6 commits into from
Oct 28, 2024

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Oct 28, 2024

Description

This PR validates the chain id before handling the deeplink for making an ethereum send.

Related issues

Fixes: 11966

Manual testing steps

  1. Open the deeplink https://metamask.app.link/send/0x2990079bcdEe240329a520d2444386FC119da21a@56?value=3e18
  2. Ensure that BNB is not added as a chain on the wallet
  3. You should see an error "Unable to find network with chain id"

Screenshots/Recordings

send-deeplink-fix.MP4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 28, 2024
@elefantel elefantel self-assigned this Oct 28, 2024
@elefantel elefantel requested review from a team as code owners October 28, 2024 11:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sdk SDK team label Oct 28, 2024
Copy link

@elefantel elefantel added the E2E label Oct 28, 2024
@christopherferreira9 christopherferreira9 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
@elefantel elefantel removed the E2E label Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 898eb26
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0df53322-e7fe-4978-90e2-3b1646d3c279

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit d1a58ab Oct 28, 2024
46 of 48 checks passed
@sethkfman sethkfman deleted the fix-send-deeplink-handling branch October 28, 2024 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 28, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-sdk SDK team
Projects
Archived in project
5 participants