Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump @metamask/preferences-controller from ^11.0.0 to ^13.1.0 #12055

Merged
merged 5 commits into from
Oct 30, 2024
Merged

chore: bump @metamask/preferences-controller from ^11.0.0 to ^13.1.0 #12055

merged 5 commits into from
Oct 30, 2024
+236 −333

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Oct 28, 2024 •
edited
Loading

Description

This PR bumps @metamask/preferences-controller from ^11.0.0 to ^13.1.0

Related issues

Fixes: #11043

Manual testing steps

Screenshots/Recordings

Before

After

preferences-controller-bump.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s self-assigned this Oct 28, 2024
@cryptodev-2s cryptodev-2s requested review from a team as code owners October 28, 2024 18:38
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-preferences-controller-13.1.0 branch 2 times, most recently from fd4390f to e1b7c53 Compare October 28, 2024 18:40
@cryptodev-2s cryptodev-2s added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e1b7c53
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b317b143-8837-42ea-842e-ddbf0db93db7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

vinnyhoward
vinnyhoward previously approved these changes Oct 28, 2024
View reviewed changes
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: eaed3ce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54c75c8a-f95d-437a-a7f8-35f4a3df761e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-preferences-controller-13.1.0 branch from eaed3ce to fe2fd24 Compare October 28, 2024 21:45
@socket-security Socket Security
Copy link

socket-security bot commented Oct 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/preferences-controller@13.1.0 None 0 124 kB metamaskbot

🚮 Removed packages: npm/@metamask/preferences-controller@11.0.0

View full report↗︎

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: fe2fd24
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e3e5ae44-4d7d-4066-8b8b-a453a837c1b6

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-preferences-controller-13.1.0 branch from fe2fd24 to 90aff61 Compare October 28, 2024 21:56
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 90aff61
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6b5755f9-23c2-4b14-92f2-196148498f86

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-preferences-controller-13.1.0 branch from 90aff61 to 997965a Compare October 29, 2024 10:11
@cryptodev-2s cryptodev-2s removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 29, 2024
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3dfaedf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7dce9702-4950-4846-8132-2bfb1e1a700a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sahar-fehri
sahar-fehri previously approved these changes Oct 30, 2024
View reviewed changes
tommasini
tommasini previously approved these changes Oct 30, 2024
View reviewed changes
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Oct 30, 2024
@cryptodev-2s cryptodev-2s removed this pull request from the merge queue due to a manual request Oct 30, 2024
@cryptodev-2s cryptodev-2s dismissed stale reviews from tommasini and sahar-fehri via 2944d3d October 30, 2024 22:35
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2944d3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f8eb498-9f5b-482b-b3fd-afdff4a8796d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mcmire
mcmire approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 1cf60a3 Oct 30, 2024
43 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-preferences-controller-13.1.0 branch October 30, 2024 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@mcmire mcmire mcmire approved these changes

@vinnyhoward vinnyhoward Awaiting requested review from vinnyhoward

Assignees

@cryptodev-2s cryptodev-2s

Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PreferencesController upgrade from v11 to v13
6 participants
@cryptodev-2s @sahar-fehri @tommasini @mcmire @vinnyhoward @metamaskbot